Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: src/builtins.h

Issue 2042013003: [builtins] Properly optimize TypedArray/DataView accessors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address Yang's comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/builtins.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.h
diff --git a/src/builtins.h b/src/builtins.h
index f84993b25d9014779998db54423fb18185d2af42..b996bd964c637136dc695cebb33c3a41195292df 100644
--- a/src/builtins.h
+++ b/src/builtins.h
@@ -78,6 +78,9 @@ inline bool operator&(BuiltinExtraArguments lhs, BuiltinExtraArguments rhs) {
\
V(DataViewConstructor, kNone) \
V(DataViewConstructor_ConstructStub, kTargetAndNewTarget) \
+ V(DataViewPrototypeGetBuffer, kNone) \
+ V(DataViewPrototypeGetByteLength, kNone) \
+ V(DataViewPrototypeGetByteOffset, kNone) \
\
V(DateConstructor, kNone) \
V(DateConstructor_ConstructStub, kTargetAndNewTarget) \
@@ -182,6 +185,8 @@ inline bool operator&(BuiltinExtraArguments lhs, BuiltinExtraArguments rhs) {
V(SymbolConstructor, kNone) \
V(SymbolConstructor_ConstructStub, kTarget) \
\
+ V(TypedArrayPrototypeBuffer, kNone) \
+ \
V(HandleApiCall, kTargetAndNewTarget) \
V(HandleApiCallAsFunction, kNone) \
V(HandleApiCallAsConstructor, kNone) \
@@ -320,24 +325,27 @@ inline bool operator&(BuiltinExtraArguments lhs, BuiltinExtraArguments rhs) {
CODE_AGE_LIST_WITH_ARG(DECLARE_CODE_AGE_BUILTIN, V)
// Define list of builtins implemented in TurboFan (with JS linkage).
-#define BUILTIN_LIST_T(V) \
- V(FunctionPrototypeHasInstance, 2) \
- V(GeneratorPrototypeNext, 2) \
- V(GeneratorPrototypeReturn, 2) \
- V(GeneratorPrototypeThrow, 2) \
- V(MathCeil, 2) \
- V(MathClz32, 2) \
- V(MathFloor, 2) \
- V(MathLog, 2) \
- V(MathRound, 2) \
- V(MathSqrt, 2) \
- V(MathTrunc, 2) \
- V(ObjectHasOwnProperty, 2) \
- V(ArrayIsArray, 2) \
- V(StringFromCharCode, 2) \
- V(StringPrototypeCharAt, 2) \
- V(StringPrototypeCharCodeAt, 2) \
- V(AtomicsLoad, 3) \
+#define BUILTIN_LIST_T(V) \
+ V(FunctionPrototypeHasInstance, 2) \
+ V(GeneratorPrototypeNext, 2) \
+ V(GeneratorPrototypeReturn, 2) \
+ V(GeneratorPrototypeThrow, 2) \
+ V(MathCeil, 2) \
+ V(MathClz32, 2) \
+ V(MathFloor, 2) \
+ V(MathLog, 2) \
+ V(MathRound, 2) \
+ V(MathSqrt, 2) \
+ V(MathTrunc, 2) \
+ V(ObjectHasOwnProperty, 2) \
+ V(ArrayIsArray, 2) \
+ V(StringFromCharCode, 2) \
+ V(StringPrototypeCharAt, 2) \
+ V(StringPrototypeCharCodeAt, 2) \
+ V(TypedArrayPrototypeByteLength, 1) \
+ V(TypedArrayPrototypeByteOffset, 1) \
+ V(TypedArrayPrototypeLength, 1) \
+ V(AtomicsLoad, 3) \
V(AtomicsStore, 4)
// Define list of builtin handlers implemented in assembly.
@@ -670,6 +678,16 @@ class Builtins {
static void Generate_StringConstructor(MacroAssembler* masm);
static void Generate_StringConstructor_ConstructStub(MacroAssembler* masm);
+
+ // ES6 section 22.2.3.2 get %TypedArray%.prototype.byteLength
+ static void Generate_TypedArrayPrototypeByteLength(
+ CodeStubAssembler* assembler);
+ // ES6 section 22.2.3.3 get %TypedArray%.prototype.byteOffset
+ static void Generate_TypedArrayPrototypeByteOffset(
+ CodeStubAssembler* assembler);
+ // ES6 section 22.2.3.18 get %TypedArray%.prototype.length
+ static void Generate_TypedArrayPrototypeLength(CodeStubAssembler* assembler);
+
static void Generate_OnStackReplacement(MacroAssembler* masm);
static void Generate_InterruptCheck(MacroAssembler* masm);
static void Generate_StackCheck(MacroAssembler* masm);
« no previous file with comments | « src/bootstrapper.cc ('k') | src/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698