Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/codegen-ia32.cc

Issue 20420: Fix reversed arguments in comparison to a smi constant. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
===================================================================
--- src/codegen-ia32.cc (revision 1292)
+++ src/codegen-ia32.cc (working copy)
@@ -1305,8 +1305,8 @@
// Setup and call the compare stub, which expects arguments in edx
// and eax.
CompareStub stub(cc, strict);
- left_side.ToRegister(eax);
- right_side.ToRegister(edx);
+ left_side.ToRegister(edx); // Only left_side currently uses a register.
+ right_side.ToRegister(eax); // left_side is not in eax. eax is free.
Result result = frame_->CallStub(&stub, &left_side, &right_side, 0);
result.ToRegister();
__ cmp(result.reg(), 0);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698