content/browser/webui/web_ui_impl.cc - Issue 2041993002: WebUI: Fix lifecycle-bug when RenderFrameHost is swapped out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/web_ui_impl.cc

Issue 2041993002: WebUI: Fix lifecycle-bug when RenderFrameHost is swapped out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/webui/web_ui_impl.h ('k') | content/browser/webui/web_ui_message_handler.cc » ('j') | content/public/browser/web_ui_message_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/webui/web_ui_impl.cc

diff --git a/content/browser/webui/web_ui_impl.cc b/content/browser/webui/web_ui_impl.cc

index 41fc037852c786645705881beed7ad9ca6d0e0fa..7d90bfa4f07b9739cb16cd76120604e8547f0bed 100644

--- a/content/browser/webui/web_ui_impl.cc

+++ b/content/browser/webui/web_ui_impl.cc

@@ -100,6 +100,11 @@ void WebUIImpl::RenderViewReused(RenderViewHost* render_view_host,

handler->RenderViewReused();

}

+void WebUIImpl::RenderFrameHostSwappingOut() {

+ for (WebUIMessageHandler* handler : handlers_)

+ handler->RenderFrameHostSwappingOut();

Dan Beam 2016/06/06 23:41:46 why wouldn't we just call DisallowJavascript() dir

tommycli 2016/06/07 17:46:07 Done.

WebContents* WebUIImpl::GetWebContents() const {

return web_contents_;

}

« no previous file with comments | « content/browser/webui/web_ui_impl.h ('k') | content/browser/webui/web_ui_message_handler.cc » ('j') | content/public/browser/web_ui_message_handler.h » ('J')