Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: content/browser/webui/web_ui_impl.h

Issue 2041993002: WebUI: Fix lifecycle-bug when RenderFrameHost is swapped out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEBUI_WEB_UI_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEBUI_WEB_UI_IMPL_H_
6 #define CONTENT_BROWSER_WEBUI_WEB_UI_IMPL_H_ 6 #define CONTENT_BROWSER_WEBUI_WEB_UI_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 18 matching lines...) Expand all
29 29
30 // Called when a RenderView is created for a WebUI (reload after a renderer 30 // Called when a RenderView is created for a WebUI (reload after a renderer
31 // crash) or when a WebUI is created for an RenderView (i.e. navigating from 31 // crash) or when a WebUI is created for an RenderView (i.e. navigating from
32 // chrome://downloads to chrome://bookmarks) or when both are new (i.e. 32 // chrome://downloads to chrome://bookmarks) or when both are new (i.e.
33 // opening a new tab). 33 // opening a new tab).
34 void RenderViewCreated(RenderViewHost* render_view_host); 34 void RenderViewCreated(RenderViewHost* render_view_host);
35 35
36 // Called when a RenderView is reused for the same WebUI type (i.e. reload). 36 // Called when a RenderView is reused for the same WebUI type (i.e. reload).
37 void RenderViewReused(RenderViewHost* render_view_host, bool was_main_frame); 37 void RenderViewReused(RenderViewHost* render_view_host, bool was_main_frame);
38 38
39 // Called when the owning RenderFrameHost has started swapping out.
40 void RenderFrameHostSwappingOut();
41
39 // WebUI implementation: 42 // WebUI implementation:
40 WebContents* GetWebContents() const override; 43 WebContents* GetWebContents() const override;
41 WebUIController* GetController() const override; 44 WebUIController* GetController() const override;
42 void SetController(WebUIController* controller) override; 45 void SetController(WebUIController* controller) override;
43 float GetDeviceScaleFactor() const override; 46 float GetDeviceScaleFactor() const override;
44 const base::string16& GetOverriddenTitle() const override; 47 const base::string16& GetOverriddenTitle() const override;
45 void OverrideTitle(const base::string16& title) override; 48 void OverrideTitle(const base::string16& title) override;
46 ui::PageTransition GetLinkTransitionType() const override; 49 ui::PageTransition GetLinkTransitionType() const override;
47 void SetLinkTransitionType(ui::PageTransition type) override; 50 void SetLinkTransitionType(ui::PageTransition type) override;
48 int GetBindings() const override; 51 int GetBindings() const override;
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 const std::string frame_name_; 122 const std::string frame_name_;
120 123
121 std::unique_ptr<WebUIController> controller_; 124 std::unique_ptr<WebUIController> controller_;
122 125
123 DISALLOW_COPY_AND_ASSIGN(WebUIImpl); 126 DISALLOW_COPY_AND_ASSIGN(WebUIImpl);
124 }; 127 };
125 128
126 } // namespace content 129 } // namespace content
127 130
128 #endif // CONTENT_BROWSER_WEBUI_WEB_UI_IMPL_H_ 131 #endif // CONTENT_BROWSER_WEBUI_WEB_UI_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_browsertest.cc ('k') | content/browser/webui/web_ui_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698