Chromium Code Reviews Chromium Code Reviews
Issue 2041993002:
WebUI: Fix lifecycle-bug when RenderFrameHost is swapped out (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_ | 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_ |
| 6 #define CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_ | 6 #define CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_ |
| 7 | 7 |
| 8 #include <vector> | 8 #include <vector> |
| 9 | 9 |
| 10 #include "base/gtest_prod_util.h" | 10 #include "base/gtest_prod_util.h" |
| (...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 99 | 99 |
| 100 private: | 100 private: |
| 101 // Provide external classes access to web_ui(), set_web_ui(), and | 101 // Provide external classes access to web_ui(), set_web_ui(), and |
| 102 // RenderViewReused. | 102 // RenderViewReused. |
| 103 friend class WebUIImpl; | 103 friend class WebUIImpl; |
| 104 friend class ::WebUIBrowserTest; | 104 friend class ::WebUIBrowserTest; |
| 105 | 105 |
| 106 // Called when a RenderView is reused to display a page (i.e. reload). | 106 // Called when a RenderView is reused to display a page (i.e. reload). |
| 107 void RenderViewReused(); | 107 void RenderViewReused(); |
| 108 | 108 |
| 109 // Called when the owning RenderFrameHost has started swapping out. | |
| 110 void RenderFrameHostSwappingOut(); | |
|
Charlie Reis
2016/06/06 21:09:52
Kind of unfortunate to be including something abou
Dan Beam
2016/06/06 23:41:46
i think it's easy to avoid
tommycli
2016/06/07 17:46:07
Done.
| |
| 111 | |
| 109 // TODO(dbeam): disallow JavaScript when a renderer process crashes. | 112 // TODO(dbeam): disallow JavaScript when a renderer process crashes. |
| 110 // http://crbug.com/610450 | 113 // http://crbug.com/610450 |
| 111 | 114 |
| 112 // True if the page is for JavaScript calls from this handler. | 115 // True if the page is for JavaScript calls from this handler. |
| 113 bool javascript_allowed_; | 116 bool javascript_allowed_; |
| 114 | 117 |
| 115 WebUI* web_ui_; | 118 WebUI* web_ui_; |
| 116 }; | 119 }; |
| 117 | 120 |
| 118 } // namespace content | 121 } // namespace content |
| 119 | 122 |
| 120 #endif // CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_ | 123 #endif // CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_ |
| OLD | NEW |
