components/offline_pages/stub_offline_page_model.h - Issue 2041983006: [Offline Pages] Filtering expired pages and fix consistency check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/stub_offline_page_model.h

Issue 2041983006: [Offline Pages] Filtering expired pages and fix consistency check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor name changes. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages/stub_offline_page_model.h

diff --git a/components/offline_pages/stub_offline_page_model.h b/components/offline_pages/stub_offline_page_model.h

index 45102e130c4cf7d7d1f5c534736185ec6d79a7bc..c17773ef05aae27c64c716d70803a5d761d0e196 100644

--- a/components/offline_pages/stub_offline_page_model.h

+++ b/components/offline_pages/stub_offline_page_model.h

@@ -62,7 +62,7 @@ class StubOfflinePageModel : public OfflinePageModel {

const SingleOfflinePageItemCallback callback) override;

const OfflinePageItem* MaybeGetBestPageForOnlineURL(

const GURL& online_url) const override;

- void CheckForExternalFileDeletion() override;

+ void CheckMetadataConsistency() override;

void ExpirePages(const std::vector<int64_t>& offline_ids,

const base::Time& expiration_time,

const base::Callback<void(bool)>& callback) override;

« no previous file with comments | « components/offline_pages/offline_page_test_store.cc ('k') | components/offline_pages/stub_offline_page_model.cc » ('j') | no next file with comments »