components/offline_pages/stub_offline_page_model.cc - Issue 2041983006: [Offline Pages] Filtering expired pages and fix consistency check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/stub_offline_page_model.cc

Issue 2041983006: [Offline Pages] Filtering expired pages and fix consistency check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments and some naming changes. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/offline_page_model_impl_unittest.cc ('K') | « components/offline_pages/stub_offline_page_model.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/stub_offline_page_model.cc

diff --git a/components/offline_pages/stub_offline_page_model.cc b/components/offline_pages/stub_offline_page_model.cc

index 956ea0be39fa7152c167379692aafc25d3dedd1e..ba9f5b2b313c3ef3b19c4ba29c32f7796a111f6a 100644

--- a/components/offline_pages/stub_offline_page_model.cc

+++ b/components/offline_pages/stub_offline_page_model.cc

@@ -63,7 +63,7 @@ const OfflinePageItem* StubOfflinePageModel::MaybeGetBestPageForOnlineURL(

const GURL& online_url) const {

return nullptr;

}

-void StubOfflinePageModel::CheckForExternalFileDeletion() {}

+void StubOfflinePageModel::CheckMetadataConsistency() {}

void StubOfflinePageModel::ExpirePages(

const std::vector<int64_t>& offline_ids,

const base::Time& expiration_time,