Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: components/offline_pages/offline_page_model.h

Issue 2041983006: [Offline Pages] Filtering expired pages and fix consistency check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments and some naming changes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.h
diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h
index b1c923ed61ae172f9159a94fac16e3ab7b177727..065766e47374b2c4e1e7c8958b655b497ae0c370 100644
--- a/components/offline_pages/offline_page_model.h
+++ b/components/offline_pages/offline_page_model.h
@@ -57,8 +57,6 @@ class OfflinePageModel : public base::SupportsUserData {
virtual void OfflinePageModelChanged(OfflinePageModel* model) = 0;
// Invoked when an offline copy related to |offline_id| was deleted.
- // In can be invoked as a result of |CheckForExternalFileDeletion|, if a
- // deleted page is detected.
virtual void OfflinePageDeleted(int64_t offline_id,
const ClientId& client_id) = 0;
@@ -179,11 +177,12 @@ class OfflinePageModel : public base::SupportsUserData {
virtual const OfflinePageItem* MaybeGetBestPageForOnlineURL(
const GURL& online_url) const = 0;
- // Checks that all of the offline pages have corresponding offline copies.
+ // Checks that all of the offline pages have corresponding offline copies,
+ // and all archived files have offline pages pointing to them.
// If a page is discovered to be missing an offline copy, its offline page
- // metadata will be removed and |OfflinePageDeleted| will be sent to model
- // observers.
- virtual void CheckForExternalFileDeletion() = 0;
+ // metadata will be expired. If an archive file is discovered missing its
+ // offline page, it will be deleted.
+ virtual void CheckMetadataConsistency() = 0;
// Marks pages with |offline_ids| as expired and deletes the associated
// archive files.

Powered by Google App Engine
This is Rietveld 408576698