src/lookup.cc - Issue 2041963003: [elements] Precisely estimate elements size for large-object limits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 2041963003: [elements] Precisely estimate elements size for large-object limits (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add missing method on string wrapper Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index 98aab68c6d94e345f7925cdf5d5a086b669cbf9d..dc735c7ef35f7db99bf3a3ef9fd59728c22960e8 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -804,7 +804,8 @@ LookupIterator::State LookupIterator::LookupInRegularHolder(

JSObject* js_object = JSObject::cast(holder);

ElementsAccessor* accessor = js_object->GetElementsAccessor();

FixedArrayBase* backing_store = js_object->elements();

- number_ = accessor->GetEntryForIndex(js_object, backing_store, index_);

+ number_ =

+ accessor->GetEntryForIndex(isolate_, js_object, backing_store, index_);

if (number_ == kMaxUInt32) {

return holder->IsJSTypedArray() ? INTEGER_INDEXED_EXOTIC : NOT_FOUND;

}

« no previous file with comments | « src/factory.cc ('k') | src/objects.h » ('j') | no next file with comments »