Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Side by Side Diff: src/lookup.cc

Issue 2041963003: [elements] Precisely estimate elements size for large-object limits (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/lookup.h" 5 #include "src/lookup.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/elements.h" 9 #include "src/elements.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 Map* const map, JSReceiver* const holder) { 721 Map* const map, JSReceiver* const holder) {
722 DisallowHeapAllocation no_gc; 722 DisallowHeapAllocation no_gc;
723 if (interceptor_state_ == InterceptorState::kProcessNonMasking) { 723 if (interceptor_state_ == InterceptorState::kProcessNonMasking) {
724 return NOT_FOUND; 724 return NOT_FOUND;
725 } 725 }
726 726
727 if (is_element) { 727 if (is_element) {
728 JSObject* js_object = JSObject::cast(holder); 728 JSObject* js_object = JSObject::cast(holder);
729 ElementsAccessor* accessor = js_object->GetElementsAccessor(); 729 ElementsAccessor* accessor = js_object->GetElementsAccessor();
730 FixedArrayBase* backing_store = js_object->elements(); 730 FixedArrayBase* backing_store = js_object->elements();
731 number_ = accessor->GetEntryForIndex(js_object, backing_store, index_); 731 number_ =
732 accessor->GetEntryForIndex(isolate_, js_object, backing_store, index_);
732 if (number_ == kMaxUInt32) { 733 if (number_ == kMaxUInt32) {
733 return holder->IsJSTypedArray() ? INTEGER_INDEXED_EXOTIC : NOT_FOUND; 734 return holder->IsJSTypedArray() ? INTEGER_INDEXED_EXOTIC : NOT_FOUND;
734 } 735 }
735 property_details_ = accessor->GetDetails(js_object, number_); 736 property_details_ = accessor->GetDetails(js_object, number_);
736 } else if (!map->is_dictionary_map()) { 737 } else if (!map->is_dictionary_map()) {
737 DescriptorArray* descriptors = map->instance_descriptors(); 738 DescriptorArray* descriptors = map->instance_descriptors();
738 int number = descriptors->SearchWithCache(isolate_, *name_, map); 739 int number = descriptors->SearchWithCache(isolate_, *name_, map);
739 if (number == DescriptorArray::kNotFound) return NotFound(holder); 740 if (number == DescriptorArray::kNotFound) return NotFound(holder);
740 number_ = static_cast<uint32_t>(number); 741 number_ = static_cast<uint32_t>(number);
741 property_details_ = descriptors->GetDetails(number_); 742 property_details_ = descriptors->GetDetails(number_);
(...skipping 11 matching lines...) Expand all
753 case v8::internal::kAccessor: 754 case v8::internal::kAccessor:
754 return ACCESSOR; 755 return ACCESSOR;
755 } 756 }
756 757
757 UNREACHABLE(); 758 UNREACHABLE();
758 return state_; 759 return state_;
759 } 760 }
760 761
761 } // namespace internal 762 } // namespace internal
762 } // namespace v8 763 } // namespace v8
OLDNEW
« src/elements.cc ('K') | « src/elements.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698