SkLeanWindows.h: #include "Windows.h" fewer places

include/private/SkRecords.h

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkRecords_DEFINED
 #define SkRecords_DEFINED
 
 #include "SkData.h"
 #include "SkCanvas.h"
 #include "SkDrawable.h"
 #include "SkImageFilter.h"
 #include "SkMatrix.h"
 #include "SkPath.h"
 #include "SkPicture.h"
 #include "SkRect.h"
 #include "SkRRect.h"
 #include "SkRSXform.h"
 #include "SkString.h"
 #include "SkTextBlob.h"
 
 namespace SkRecords {
 
+#ifdef DrawText

[bungeman-skia, 2016/06/06 18:11:59]

We should put a short comment here that windows.h defines DrawText to DrawTextA
or DrawTextW and we want to avoid that. Just so someone in the future doesn't
wonder too hard why this is here.

See comment at the top of src/ports/SkTypeface_win_dw.cpp for a similar issue.

[hal.canary, 2016/06/06 18:22:32]

Done.

+#undef DrawText
+#endif
+
 // A list of all the types of canvas calls we can record.
 // Each of these is reified into a struct below.
 //
 // (We're using the macro-of-macro trick here to do several different things with the same list.)
 //
 // We leave this SK_RECORD_TYPES macro defined for use by code that wants to operate on SkRecords
 // types polymorphically.  (See SkRecord::Record::{visit,mutate} for an example.)
 //
 // Order doesn't technically matter here, but the compiler can generally generate better code if
 // you keep them semantically grouped, especially the Draws.  It's also nice to leave NoOp at 0.
@@ skipping 327 matching lines @@
         int indexCount);
 RECORD(DrawAnnotation, 0,
        SkRect rect;
        SkString key;
        RefBox<SkData> value);
 #undef RECORD
 
 }  // namespace SkRecords
 
 #endif//SkRecords_DEFINED