Add user agent to System Context Getter as suggested by metrics team.

Add user agent to System Context Getter as suggested by metrics team.

Currently the user agent is set to empty string which results in the
upload being ignored by the metrics service.

Setting this value will allow for processing and display of metrics
for Blimp.

BUG=592757
Committed: https://crrev.com/117048d26a9409d12988e63985ad9c6181f4838d
Cr-Commit-Position: refs/heads/master@{#398155}

[Jess, 2016-06-06 17:29:46]

jessicag@chromium.org changed reviewers:
+ kmarshall@chromium.org

[Kevin M, 2016-06-06 22:00:18]

lgtm % comment nits

https://codereview.chromium.org/2041933002/diff/1/blimp/engine/app/blimp_syst...
File blimp/engine/app/blimp_system_url_request_context_getter.cc (right):

https://codereview.chromium.org/2041933002/diff/1/blimp/engine/app/blimp_syst...
blimp/engine/app/blimp_system_url_request_context_getter.cc:22: // Must first be
created on the UI thread.
IMO the code already makes this clear :)

https://codereview.chromium.org/2041933002/diff/1/blimp/engine/app/blimp_syst...
blimp/engine/app/blimp_system_url_request_context_getter.cc:34: //
TODO(jessicag): See if proxy_service setup should be harmonized with
Put newlines before comments

https://codereview.chromium.org/2041933002/diff/1/blimp/engine/app/blimp_syst...
blimp/engine/app/blimp_system_url_request_context_getter.cc:37: // Metrics
service ignores upload without appropriate user agent.
Comment seems unnecessarily defensive - it's reasonable to assume that the code
is there for a reason.

[Jess, 2016-06-06 22:10:38]

https://codereview.chromium.org/2041933002/diff/1/blimp/engine/app/blimp_syst...
File blimp/engine/app/blimp_system_url_request_context_getter.cc (right):

https://codereview.chromium.org/2041933002/diff/1/blimp/engine/app/blimp_syst...
blimp/engine/app/blimp_system_url_request_context_getter.cc:22: // Must first be
created on the UI thread.
On 2016/06/06 22:00:17, Kevin M wrote:
> IMO the code already makes this clear :)

Removed.

https://codereview.chromium.org/2041933002/diff/1/blimp/engine/app/blimp_syst...
blimp/engine/app/blimp_system_url_request_context_getter.cc:34: //
TODO(jessicag): See if proxy_service setup should be harmonized with
On 2016/06/06 22:00:17, Kevin M wrote:
> Put newlines before comments

Done.

https://codereview.chromium.org/2041933002/diff/1/blimp/engine/app/blimp_syst...
blimp/engine/app/blimp_system_url_request_context_getter.cc:37: // Metrics
service ignores upload without appropriate user agent.
On 2016/06/06 22:00:17, Kevin M wrote:
> Comment seems unnecessarily defensive - it's reasonable to assume that the
code
> is there for a reason.

Done.

[Jess, 2016-06-06 22:16:06]

The CQ bit was checked by jessicag@chromium.org

[Jess, 2016-06-06 22:16:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
kmarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2041933002/#ps20001
(title: "Update comments as suggested.")

[commit-bot: I haz the power, 2016-06-06 22:16:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041933002/20001

[commit-bot: I haz the power, 2016-06-06 22:59:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-06 23:01:12]

Description was changed from

==========
Add user agent to System Context Getter as suggested by metrics team.

Currently the user agent is set to empty string which results in the
upload being ignored by the metrics service.

Setting this value will allow for processing and display of metrics
for Blimp.

BUG=592757
==========

to

==========
Add user agent to System Context Getter as suggested by metrics team.

Currently the user agent is set to empty string which results in the
upload being ignored by the metrics service.

Setting this value will allow for processing and display of metrics
for Blimp.

BUG=592757

Committed: https://crrev.com/117048d26a9409d12988e63985ad9c6181f4838d
Cr-Commit-Position: refs/heads/master@{#398155}
==========

[commit-bot: I haz the power, 2016-06-06 23:01:13]

Patchset 2 (id:??) landed as
https://crrev.com/117048d26a9409d12988e63985ad9c6181f4838d
Cr-Commit-Position: refs/heads/master@{#398155}