Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: src/interpreter/bytecode-peephole-optimizer.cc

Issue 2041913002: [interpreter] Remove OperandScale from front stages of pipeline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Minor clean-up. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-peephole-optimizer.cc
diff --git a/src/interpreter/bytecode-peephole-optimizer.cc b/src/interpreter/bytecode-peephole-optimizer.cc
index 790b270abddf3cccb90ba3a6b834c1a87795891f..d8647d9399d8d4467bc9c1688802ab4cd255e846 100644
--- a/src/interpreter/bytecode-peephole-optimizer.cc
+++ b/src/interpreter/bytecode-peephole-optimizer.cc
@@ -183,9 +183,8 @@ void TransformLdaStarToLdrLdar(Bytecode new_bytecode, BytecodeNode* const last,
// accumulator. However, in the second form the Ldar can often be
// peephole optimized away unlike the Star in the first form.
//
- last->Transform(new_bytecode, current->operand(0), current->operand_scale());
- current->set_bytecode(Bytecode::kLdar, current->operand(0),
- current->operand_scale());
+ last->Transform(new_bytecode, current->operand(0));
+ current->set_bytecode(Bytecode::kLdar, current->operand(0));
// If there was a source position on |current| transfer it to the
// updated |last| to maintain the debugger's causal view. ie. if an
@@ -234,7 +233,7 @@ bool BytecodePeepholeOptimizer::RemoveToBooleanFromJump(
// element can be removed if the previous bytecode put a boolean
// value in the accumulator.
Bytecode jump = Bytecodes::GetJumpWithoutToBoolean(current->bytecode());
- current->set_bytecode(jump, current->operand(0), current->operand_scale());
+ current->set_bytecode(jump, current->operand(0));
}
return can_remove;
}

Powered by Google App Engine
This is Rietveld 408576698