Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: test/unittests/interpreter/bytecodes-unittest.cc

Issue 2041913002: [interpreter] Remove OperandScale from front stages of pipeline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/interpreter/bytecode-register-optimizer-unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/bytecodes-unittest.cc
diff --git a/test/unittests/interpreter/bytecodes-unittest.cc b/test/unittests/interpreter/bytecodes-unittest.cc
index 6bc5ababf62574093900e0a6493c00fec319296d..74a2bb3793dfd8daff54bd7d763ef6e375d6da80 100644
--- a/test/unittests/interpreter/bytecodes-unittest.cc
+++ b/test/unittests/interpreter/bytecodes-unittest.cc
@@ -254,35 +254,6 @@ TEST(Bytecodes, PrefixMappings) {
}
}
-TEST(Bytecodes, OperandScales) {
- CHECK_EQ(Bytecodes::OperandSizesToScale(OperandSize::kByte),
- OperandScale::kSingle);
- CHECK_EQ(Bytecodes::OperandSizesToScale(OperandSize::kShort),
- OperandScale::kDouble);
- CHECK_EQ(Bytecodes::OperandSizesToScale(OperandSize::kQuad),
- OperandScale::kQuadruple);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kShort, OperandSize::kShort,
- OperandSize::kShort, OperandSize::kShort),
- OperandScale::kDouble);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kQuad, OperandSize::kShort,
- OperandSize::kShort, OperandSize::kShort),
- OperandScale::kQuadruple);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kShort, OperandSize::kQuad,
- OperandSize::kShort, OperandSize::kShort),
- OperandScale::kQuadruple);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kShort, OperandSize::kShort,
- OperandSize::kQuad, OperandSize::kShort),
- OperandScale::kQuadruple);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kShort, OperandSize::kShort,
- OperandSize::kShort, OperandSize::kQuad),
- OperandScale::kQuadruple);
-}
-
TEST(Bytecodes, SizesForSignedOperands) {
CHECK(Bytecodes::SizeForSignedOperand(0) == OperandSize::kByte);
CHECK(Bytecodes::SizeForSignedOperand(kMaxInt8) == OperandSize::kByte);
@@ -332,35 +303,6 @@ TEST(OperandScale, PrefixesRequired) {
Bytecode::kExtraWide);
}
-TEST(Bytecodes, OperandSizesToScale) {
- CHECK_EQ(Bytecodes::OperandSizesToScale(OperandSize::kByte),
- OperandScale::kSingle);
- CHECK_EQ(Bytecodes::OperandSizesToScale(OperandSize::kShort),
- OperandScale::kDouble);
- CHECK_EQ(Bytecodes::OperandSizesToScale(OperandSize::kQuad),
- OperandScale::kQuadruple);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kShort, OperandSize::kShort,
- OperandSize::kShort, OperandSize::kShort),
- OperandScale::kDouble);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kQuad, OperandSize::kShort,
- OperandSize::kShort, OperandSize::kShort),
- OperandScale::kQuadruple);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kShort, OperandSize::kQuad,
- OperandSize::kShort, OperandSize::kShort),
- OperandScale::kQuadruple);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kShort, OperandSize::kShort,
- OperandSize::kQuad, OperandSize::kShort),
- OperandScale::kQuadruple);
- CHECK_EQ(
- Bytecodes::OperandSizesToScale(OperandSize::kShort, OperandSize::kShort,
- OperandSize::kShort, OperandSize::kQuad),
- OperandScale::kQuadruple);
-}
-
TEST(AccumulatorUse, LogicalOperators) {
CHECK_EQ(AccumulatorUse::kNone | AccumulatorUse::kRead,
AccumulatorUse::kRead);
« no previous file with comments | « test/unittests/interpreter/bytecode-register-optimizer-unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698