Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2041873003: Fix @protected to include closure references (linter#255). (Closed)

Created:
4 years, 6 months ago by pquitslund
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix @protected to include closure references (linter#255). Generalizes the check for invalid protected access. R=brianwilkerson@google.com Fixes: https://github.com/dart-lang/linter/issues/255. Committed: https://github.com/dart-lang/sdk/commit/8b779f33c01e4a62b5976e24f1ffeb7e8f023d81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -45 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +20 lines, -45 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-06 18:13:13 UTC) #2
pquitslund
4 years, 6 months ago (2016-06-06 18:43:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b779f33c01e4a62b5976e24f1ffeb7e8f023d81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698