Remove HttpServerProperies::GetWeakPtr().

net/spdy/spdy_session_pool.h

Index: net/spdy/spdy_session_pool.h
diff --git a/net/spdy/spdy_session_pool.h b/net/spdy/spdy_session_pool.h
index 13664dc527fbab9addef65ed80b97aa6e94a217b..a7cb5a6fc05e71cd74abb3ab9592e16e93934255 100644
--- a/net/spdy/spdy_session_pool.h
+++ b/net/spdy/spdy_session_pool.h
@@ -49,18 +49,17 @@ class NET_EXPORT SpdySessionPool
   // |default_protocol| may be kProtoUnknown (e.g., if SPDY is
   // disabled), in which case it's set to a default value. Otherwise,
   // it must be a SPDY protocol.
-  SpdySessionPool(
-      HostResolver* host_resolver,
-      SSLConfigService* ssl_config_service,
-      const base::WeakPtr<HttpServerProperties>& http_server_properties,
-      TransportSecurityState* transport_security_state,
-      bool enable_ping_based_connection_checking,
-      bool enable_priority_dependencies,
-      NextProto default_protocol,
-      size_t session_max_recv_window_size,
-      size_t stream_max_recv_window_size,
-      SpdySessionPool::TimeFunc time_func,
-      ProxyDelegate* proxy_delegate);
+  SpdySessionPool(HostResolver* host_resolver,
+                  SSLConfigService* ssl_config_service,
+                  HttpServerProperties* const http_server_properties,

[asanka, 2016/06/07 20:19:56]

Same comment as above. 'const' applies to the value of the pointer and isn't
meaningful in a declaration.

[Bence, 2016/06/08 18:27:18]

Done.

+                  TransportSecurityState* transport_security_state,
+                  bool enable_ping_based_connection_checking,
+                  bool enable_priority_dependencies,
+                  NextProto default_protocol,
+                  size_t session_max_recv_window_size,
+                  size_t stream_max_recv_window_size,
+                  SpdySessionPool::TimeFunc time_func,
+                  ProxyDelegate* proxy_delegate);
   ~SpdySessionPool() override;
 
   // In the functions below, a session is "available" if this pool has
@@ -133,7 +132,7 @@ class NET_EXPORT SpdySessionPool
   // Creates a Value summary of the state of the spdy session pool.
   std::unique_ptr<base::Value> SpdySessionPoolInfoToValue() const;
 
-  base::WeakPtr<HttpServerProperties> http_server_properties() {
+  HttpServerProperties* http_server_properties() const {

[asanka, 2016/06/07 20:19:56]

Minor nit: This shouldn't be const unless you are returning a 'const
HttpServerProperties*' since technically the server properties are a part of the
state affecting |this|.

Not a style violation as far as I could find, so up to you.

[Bence, 2016/06/08 18:27:18]

Done.  Made the same change to ChromeBrowserStateIOData, also removing const
qualifier from set_http_server_properties member.

Note that there is a similar issue with ProfileIOData and UrlRequestContext, but
(1) the const qualifier was already there, it's not introduced by this CL, and
(2) I cannot remove it easily because methods are called on const instances.

     return http_server_properties_;
   }
 
@@ -197,7 +196,7 @@ class NET_EXPORT SpdySessionPool
       const std::string& description,
       bool idle_only);
 
-  const base::WeakPtr<HttpServerProperties> http_server_properties_;
+  HttpServerProperties* const http_server_properties_;
 
   TransportSecurityState* transport_security_state_;