Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | net/socket/ssl_client_socket_pool_unittest.cc » ('j') | net/spdy/spdy_session.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory_test.cc
diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc
index 95a093a9492e775d73993ea5097f7ab691b0a817..a5e1db1e994014147d8466713de7afd31d809a68 100644
--- a/net/quic/quic_stream_factory_test.cc
+++ b/net/quic/quic_stream_factory_test.cc
@@ -312,7 +312,7 @@ class QuicStreamFactoryTestBase {
DCHECK(!factory_);
factory_.reset(new QuicStreamFactory(
net_log_.net_log(), &host_resolver_, &socket_factory_,
- http_server_properties_.GetWeakPtr(), cert_verifier_.get(), nullptr,
+ &http_server_properties_, cert_verifier_.get(), nullptr,
channel_id_service_.get(), &transport_security_state_,
cert_transparency_verifier_.get(),
/*SocketPerformanceWatcherFactory*/ nullptr,
@@ -3735,8 +3735,7 @@ TEST_P(QuicStreamFactoryTest, MaybeInitialize) {
QuicServerId quic_server_id(kDefaultServerHostName, 80,
PRIVACY_MODE_DISABLED);
QuicServerInfoFactory* quic_server_info_factory =
- new PropertiesBasedQuicServerInfoFactory(
- http_server_properties_.GetWeakPtr());
+ new PropertiesBasedQuicServerInfoFactory(&http_server_properties_);
factory_->set_quic_server_info_factory(quic_server_info_factory);
std::unique_ptr<QuicServerInfo> quic_server_info(
« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | net/socket/ssl_client_socket_pool_unittest.cc » ('j') | net/spdy/spdy_session.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698