net/quic/crypto/properties_based_quic_server_info.cc - Issue 2041863002: Remove HttpServerProperies::GetWeakPtr().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/properties_based_quic_server_info.cc

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/crypto/properties_based_quic_server_info.cc

diff --git a/net/quic/crypto/properties_based_quic_server_info.cc b/net/quic/crypto/properties_based_quic_server_info.cc

index 708f44a4f4a1246554dc9d05676a9c3e837b1e69..5522f6c06064dc71503c4733d7caaf08057049c2 100644

--- a/net/quic/crypto/properties_based_quic_server_info.cc

+++ b/net/quic/crypto/properties_based_quic_server_info.cc

@@ -14,7 +14,7 @@ namespace net {

PropertiesBasedQuicServerInfo::PropertiesBasedQuicServerInfo(

const QuicServerId& server_id,

- base::WeakPtr<HttpServerProperties> http_server_properties)

+ HttpServerProperties* http_server_properties)

: QuicServerInfo(server_id),

http_server_properties_(http_server_properties) {

DCHECK(http_server_properties_);

@@ -55,7 +55,7 @@ void PropertiesBasedQuicServerInfo::Persist() {

void PropertiesBasedQuicServerInfo::OnExternalCacheHit() {}

PropertiesBasedQuicServerInfoFactory::PropertiesBasedQuicServerInfoFactory(

- base::WeakPtr<HttpServerProperties> http_server_properties)

+ HttpServerProperties* http_server_properties)

: http_server_properties_(http_server_properties) {}

PropertiesBasedQuicServerInfoFactory::~PropertiesBasedQuicServerInfoFactory() {}