Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2041843002: [asmjs] Validator should reject assignments to heap variables in functions. (Closed)

Created:
4 years, 6 months ago by titzer
Modified:
4 years, 6 months ago
Reviewers:
aseemgarg, bradn, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asmjs] Validator should reject assignments to heap variables in functions. BUG=chromium:617529 Committed: https://crrev.com/dc98fabf1519d25b20fc0ca559692af7d0519916 Cr-Commit-Position: refs/heads/master@{#36747}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/typing-asm.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-617529.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
titzer
4 years, 6 months ago (2016-06-06 12:05:49 UTC) #2
ahaas
lgtm
4 years, 6 months ago (2016-06-06 13:24:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041843002/20001
4 years, 6 months ago (2016-06-06 13:25:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 13:27:55 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 13:30:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc98fabf1519d25b20fc0ca559692af7d0519916
Cr-Commit-Position: refs/heads/master@{#36747}

Powered by Google App Engine
This is Rietveld 408576698