Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2041833002: [turbofan] Make FindFrameStateBefore handle dead paths. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make FindFrameStateBefore handle dead paths. This makes sure {NodeProperties::FindFrameStateBefore} can deal with effect chains that are marked as dead. This can happen when reducers looking for frame states run together with other reducers killing some execution paths within the same reduction phase. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-617567 BUG=chromium:617567, chromium:617224 Committed: https://crrev.com/826627d9fd0e452a423948536076027c2b22a49b Cr-Commit-Position: refs/heads/master@{#36743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M src/compiler/node-properties.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-617567.js View 1 chunk +13 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
titzer
lgtm
4 years, 6 months ago (2016-06-06 12:14:31 UTC) #2
Michael Starzinger
4 years, 6 months ago (2016-06-06 12:15:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041833002/1
4 years, 6 months ago (2016-06-06 12:22:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 12:32:00 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 12:35:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/826627d9fd0e452a423948536076027c2b22a49b
Cr-Commit-Position: refs/heads/master@{#36743}

Powered by Google App Engine
This is Rietveld 408576698