Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204183002: Remove CompositableValue. (Closed)

Created:
6 years, 9 months ago by shans
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@opacity
Visibility:
Public.

Description

Remove CompositableValue. This should have happened as part of 194673002. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169519

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -97 lines) Patch
M Source/core/animation/AnimatableValue.h View 3 chunks +1 line, -8 lines 0 comments Download
M Source/core/animation/AnimationEffect.h View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/animation/Interpolation.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/Interpolation.cpp View 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 1 4 chunks +8 lines, -67 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
shans
6 years, 9 months ago (2014-03-19 00:43:22 UTC) #1
alancutter (OOO until 2018)
lgtm, yay code simplification!
6 years, 9 months ago (2014-03-19 00:48:28 UTC) #2
dstockwell
lgtm
6 years, 9 months ago (2014-03-19 00:49:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/204183002/20001
6 years, 9 months ago (2014-03-19 00:49:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 00:52:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-19 00:52:35 UTC) #6
shans
The CQ bit was checked by shans@chromium.org
6 years, 9 months ago (2014-03-19 00:58:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/204183002/20001
6 years, 9 months ago (2014-03-19 00:58:39 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 01:00:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-19 01:00:04 UTC) #10
shans
The CQ bit was checked by shans@chromium.org
6 years, 9 months ago (2014-03-19 01:11:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/204183002/60001
6 years, 9 months ago (2014-03-19 01:11:11 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 01:14:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 01:14:50 UTC) #14
shans
The CQ bit was checked by shans@chromium.org
6 years, 9 months ago (2014-03-19 02:15:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/204183002/60001
6 years, 9 months ago (2014-03-19 02:15:06 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 03:21:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 03:21:22 UTC) #18
shans
The CQ bit was checked by shans@chromium.org
6 years, 9 months ago (2014-03-19 03:22:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/204183002/60001
6 years, 9 months ago (2014-03-19 03:22:30 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 04:30:09 UTC) #21
Message was sent while issue was closed. 
Change committed as 169519

Powered by Google App Engine
This is Rietveld 408576698