Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2516)

Issue 2041813002: Add StringScanner.scanChar() and .expectChar(). (Closed)

Created:
4 years, 2 months ago by nweiz
Modified:
4 years, 2 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/string_scanner@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -7 lines) Patch
M CHANGELOG.md View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/eager_span_scanner.dart View 1 1 chunk +14 lines, -3 lines 0 comments Download
M lib/src/line_scanner.dart View 1 1 chunk +14 lines, -3 lines 0 comments Download
M lib/src/string_scanner.dart View 2 chunks +33 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/line_scanner_test.dart View 2 chunks +34 lines, -0 lines 0 comments Download
M test/string_scanner_test.dart View 4 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nweiz
4 years, 2 months ago (2016-06-06 23:23:04 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/2041813002/diff/1/lib/src/line_scanner.dart File lib/src/line_scanner.dart (right): https://codereview.chromium.org/2041813002/diff/1/lib/src/line_scanner.dart#newcode78 lib/src/line_scanner.dart:78: if (character == $lf || (character == $cr ...
4 years, 2 months ago (2016-06-06 23:46:51 UTC) #3
nweiz
Code review changes
4 years, 2 months ago (2016-06-06 23:51:34 UTC) #4
nweiz
4 years, 2 months ago (2016-06-06 23:52:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f83ceb2e84a60a6417c6aeb0cd2162931617461a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698