Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher.cc

Issue 2041783002: Preset variation parameters for NTPSnippets feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@about-flags-parameters
Patch Set: Removing unittests that test non-default behaviour Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/ntp_snippets/ntp_snippets_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/ntp_snippets_fetcher.cc
diff --git a/components/ntp_snippets/ntp_snippets_fetcher.cc b/components/ntp_snippets/ntp_snippets_fetcher.cc
index b7786e57eb9d7932041cb72a9e6b14188e915729..4a5308df0876214954d53a5ddfea795e9d73d947 100644
--- a/components/ntp_snippets/ntp_snippets_fetcher.cc
+++ b/components/ntp_snippets/ntp_snippets_fetcher.cc
@@ -173,12 +173,12 @@ NTPSnippetsFetcher::NTPSnippetsFetcher(
std::string host_restriction = variations::GetVariationParamValue(
ntp_snippets::kStudyName, kHostRestrictionName);
- if (host_restriction == kHostRestrictionOffString) {
- use_host_restriction_ = false;
- } else {
+ if (host_restriction == kHostRestrictionOnString) {
use_host_restriction_ = true;
+ } else {
+ use_host_restriction_ = false;
LOG_IF(WARNING, !host_restriction.empty() &&
- host_restriction != kHostRestrictionOnString)
+ host_restriction != kHostRestrictionOffString)
<< "Unknown value for " << kHostRestrictionName << ": "
<< host_restriction;
}
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/ntp_snippets/ntp_snippets_fetcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698