third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp - Issue 2041753002: Worker: Protect a running debugger task from forcible worker termination

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

Issue 2041753002: Worker: Protect a running debugger task from forcible worker termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tweak if-condition Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

index a6ae1745821100f6b4179715a1c2ed34d4a47bea..8f7d53f68da6255f6cd2f1f92f758ed886094ff9 100644

--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

@@ -76,12 +76,12 @@ int WorkerThreadDebugger::contextGroupId()

void WorkerThreadDebugger::runMessageLoopOnPause(int contextGroupId)

{

ASSERT(contextGroupId == workerContextGroupId);

- m_workerThread->startRunningDebuggerTasksOnPause();

+ m_workerThread->startRunningDebuggerTasksOnPauseOnWorkerThread();

}

void WorkerThreadDebugger::quitMessageLoopOnPause()

{

- m_workerThread->stopRunningDebuggerTasksOnPause();

+ m_workerThread->stopRunningDebuggerTasksOnPauseOnWorkerThread();

}

bool WorkerThreadDebugger::callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target)