Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2041743002: Add sync_submodules builders on master.chromium.infra. (Closed)

Created:
4 years, 6 months ago by dsansome
Modified:
4 years, 6 months ago
Reviewers:
agable
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add sync_submodules builders on master.chromium.infra. Also remove some cargo cult copy+pasting. BUG=617493 Committed: https://chromium.googlesource.com/chromium/tools/build/+/37317ef2991f28ee729fd24ec42b8f535990b797

Patch Set 1 #

Patch Set 2 : Test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -414 lines) Patch
M masters/master.chromium.infra.cron/master.cfg View 1 chunk +1 line, -6 lines 0 comments Download
M masters/master.chromium.infra/master.cfg View 4 chunks +29 lines, -30 lines 0 comments Download
M masters/master.chromium.infra/slaves.cfg View 1 chunk +11 lines, -0 lines 0 comments Download
A scripts/slave/recipes/infra/sync_submodules.py View 1 chunk +22 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/infra/sync_submodules.expected/basic.json View 1 1 chunk +0 lines, -117 lines 0 comments Download
D scripts/slave/recipes/sync_submodules.py View 1 chunk +0 lines, -20 lines 0 comments Download
D scripts/slave/recipes/sync_submodules.expected/basic.json View 1 chunk +0 lines, -241 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsansome
4 years, 6 months ago (2016-06-06 04:36:35 UTC) #2
agable
LGTM. This is changing the pollInterval from 10 to 30, but I'm fine with that.
4 years, 6 months ago (2016-06-06 17:20:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041743002/20001
4 years, 6 months ago (2016-06-07 02:59:33 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 03:04:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/37317ef2991f28ee729f...

Powered by Google App Engine
This is Rietveld 408576698