Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2041723008: Rework the parser to improve performance (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1414 lines, -930 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 203 chunks +1407 lines, -923 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This doesn't address all of the problems, but does, by my calculations, get us about ...
4 years, 6 months ago (2016-06-07 20:36:11 UTC) #2
scheglov
LGTM
4 years, 6 months ago (2016-06-07 20:53:05 UTC) #3
Brian Wilkerson
4 years, 6 months ago (2016-06-07 20:58:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e3e72aeb012cbd275fc7f81f8bf599729910cbf6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698