Issue 20417: Experimental: eliminate a few spilled scopes in function prologue and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20417: Experimental: eliminate a few spilled scopes in function prologue and... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Experimental: eliminate a few spilled scopes in function prologue and declaration code. Committed: http://code.google.com/p/v8/source/detail?r=1291

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -29 lines)			Patch
	M	src/codegen-ia32.cc	View		7 chunks	+41 lines, -29 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

We need to ultimately sort out how to use the reserved registers in code. Pushing ...

11 years, 10 months ago (2009-02-17 11:21:11 UTC) #1

William Hesse

11 years, 10 months ago (2009-02-17 13:36:19 UTC) #2

LGTM

http://codereview.chromium.org/20417/diff/1/2
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/20417/diff/1/2#newcode205
Line 205: // Loads the context register with the context, used below
"SlotOperand loads context.reg() with the context as a side effect.  This value
is used by RecordWrite, below."

Expand Messages | Collapse Messages