Clamp radial gradient end radii

Clamp radial gradient end radii

Ensure that the end radius stays within finite float range, to
avoid degenerate cases down the line.

BUG=616993
R=fs@opera.com

Committed: https://crrev.com/08e2d2a00072b39e91bfb3d8665c06fa0cc55f68
Cr-Commit-Position: refs/heads/master@{#398029}

[f(malita), 2016-06-05 16:32:38]

Description was changed from

==========
Clamp radial gradient end radii



BUG=
==========

to

==========
Clamp radial gradient end radii

Ensure that the end radius stays within finite float range, to
avoid degenerate cases down the line.

BUG=616993
R=fs@opera.com
==========

[f(malita), 2016-06-05 16:32:38]

fmalita@chromium.org changed reviewers:
+ fs@opera.com

[fs, 2016-06-05 23:34:02]

LGTM

https://codereview.chromium.org/2041653002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right):

https://codereview.chromium.org/2041653002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1058: float a =
clampTo<float>(sqrtf(p.x() * p.x() + p.y() * p.y() * aspectRatio *
aspectRatio));
Could the division on the next line potentially push this back over the edge
again? (p.x() = numeric_limits<float>::max(); aspectRatio < 1)

[f(malita), 2016-06-06 13:13:10]

https://codereview.chromium.org/2041653002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right):

https://codereview.chromium.org/2041653002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1058: float a =
clampTo<float>(sqrtf(p.x() * p.x() + p.y() * p.y() * aspectRatio *
aspectRatio));
On 2016/06/05 23:34:02, fs (OoO) wrote:
> Could the division on the next line potentially push this back over the edge
> again? (p.x() = numeric_limits<float>::max(); aspectRatio < 1)

Hrmpf, you're right.  Updated to clamp both values individually.

[f(malita), 2016-06-06 14:41:00]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-06-06 14:41:01]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2041653002/#ps40001
(title: "review")

[commit-bot: I haz the power, 2016-06-06 14:41:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041653002/40001

[commit-bot: I haz the power, 2016-06-06 15:17:29]

Description was changed from

==========
Clamp radial gradient end radii

Ensure that the end radius stays within finite float range, to
avoid degenerate cases down the line.

BUG=616993
R=fs@opera.com
==========

to

==========
Clamp radial gradient end radii

Ensure that the end radius stays within finite float range, to
avoid degenerate cases down the line.

BUG=616993
R=fs@opera.com
==========

[commit-bot: I haz the power, 2016-06-06 15:17:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-06 15:18:52]

Description was changed from

==========
Clamp radial gradient end radii

Ensure that the end radius stays within finite float range, to
avoid degenerate cases down the line.

BUG=616993
R=fs@opera.com
==========

to

==========
Clamp radial gradient end radii

Ensure that the end radius stays within finite float range, to
avoid degenerate cases down the line.

BUG=616993
R=fs@opera.com

Committed: https://crrev.com/08e2d2a00072b39e91bfb3d8665c06fa0cc55f68
Cr-Commit-Position: refs/heads/master@{#398029}
==========

[commit-bot: I haz the power, 2016-06-06 15:18:53]

Patchset 3 (id:??) landed as
https://crrev.com/08e2d2a00072b39e91bfb3d8665c06fa0cc55f68
Cr-Commit-Position: refs/heads/master@{#398029}