Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2041633002: Include <wchar.h> for mbstate_t. (Closed)

Created:
4 years, 6 months ago by Ben Chan
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include <wchar.h> for mbstate_t. mbstate_t is defined in <wchar.h>, which is often indirectly included through <string>. However, that's not true for all implementations of C++ standard library. This CL adds the missing inclusion of <wchar.h> in base/strings/string16.h for the definition of mbstate_t. BUG=None Committed: https://crrev.com/7005a6e85635037bf2785e56a94f3e1526c87fb5 Cr-Commit-Position: refs/heads/master@{#398199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/strings/string16.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041633002/1
4 years, 6 months ago (2016-06-05 06:13:06 UTC) #2
Ben Chan
4 years, 6 months ago (2016-06-05 07:38:45 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-05 08:07:58 UTC) #7
Ben Chan
4 years, 6 months ago (2016-06-06 15:38:02 UTC) #9
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-06 21:30:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041633002/1
4 years, 6 months ago (2016-06-06 21:32:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 02:19:21 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 02:22:46 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7005a6e85635037bf2785e56a94f3e1526c87fb5
Cr-Commit-Position: refs/heads/master@{#398199}

Powered by Google App Engine
This is Rietveld 408576698