content/browser/devtools/protocol/tracing_handler_unittest.cc - Issue 2041583003: [tracing] Introduce "allowed_dump_modes" for memory dump config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/tracing_handler_unittest.cc

Issue 2041583003: [tracing] Introduce "allowed_dump_modes" for memory dump config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@background_config

Patch Set: Change mode to int. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/protocol/tracing_handler_unittest.cc

diff --git a/content/browser/devtools/protocol/tracing_handler_unittest.cc b/content/browser/devtools/protocol/tracing_handler_unittest.cc

index 85b01d883abf237b4f23d7bd8851e8a5f2a33a05..6b1f7a9c3f893fdd5cefeb38e102e1778cd447e2 100644

--- a/content/browser/devtools/protocol/tracing_handler_unittest.cc

+++ b/content/browser/devtools/protocol/tracing_handler_unittest.cc

@@ -25,6 +25,7 @@ const char kCustomTraceConfigString[] =

"\"disabled-by-default-cc\","

"\"disabled-by-default-memory-infra\"],"

"\"memory_dump_config\":{"

+ "\"allowed_dump_modes\":[\"background\",\"light\",\"detailed\"],"

"\"triggers\":["

"{\"mode\":\"light\",\"periodic_interval_ms\":50},"

"{\"mode\":\"detailed\",\"periodic_interval_ms\":1000}"

@@ -45,6 +46,7 @@ const char kCustomTraceConfigStringDevToolsStyle[] =

"\"disabled-by-default-cc\","

"\"disabled-by-default-memory-infra\"],"

"\"memoryDumpConfig\":{"

+ "\"allowed_dump_modes\":[\"background\",\"light\",\"detailed\"],"

"\"triggers\":["

"{\"mode\":\"light\",\"periodicIntervalMs\":50},"

"{\"mode\":\"detailed\",\"periodicIntervalMs\":1000}"

« no previous file with comments | « base/trace_event/trace_config_unittest.cc ('k') | content/browser/tracing/background_tracing_manager_impl.cc » ('j') | no next file with comments »