base/trace_event/trace_config_memory_test_util.h - Issue 2041583003: [tracing] Introduce "allowed_dump_modes" for memory dump config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_config_memory_test_util.h

Issue 2041583003: [tracing] Introduce "allowed_dump_modes" for memory dump config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@background_config

Patch Set: rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/trace_config.cc ('K') | « base/trace_event/trace_config.cc ('k') | base/trace_event/trace_config_unittest.cc » ('j') | content/browser/tracing/background_tracing_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/trace_config_memory_test_util.h

diff --git a/base/trace_event/trace_config_memory_test_util.h b/base/trace_event/trace_config_memory_test_util.h

index 49f9a810de2c6ff85ccad94f1856029a95cf9dbd..6b47f8dc5505a13ab7de7f1fa617795a31e0d768 100644

--- a/base/trace_event/trace_config_memory_test_util.h

+++ b/base/trace_event/trace_config_memory_test_util.h

@@ -24,6 +24,7 @@ class TraceConfigMemoryTestUtil {

"\"%s\""

"],"

"\"memory_dump_config\":{"

+ "\"allowed_dump_modes\":[\"background\",\"light\",\"detailed\"],"

"\"heap_profiler_options\":{"

"\"breakdown_threshold_bytes\":2048"

"},"

@@ -52,6 +53,7 @@ class TraceConfigMemoryTestUtil {

"\"%s\""

"],"

"\"memory_dump_config\":{"

+ "\"allowed_dump_modes\":[\"background\",\"light\",\"detailed\"],"

"\"triggers\":["

"]"

"},"

@@ -82,6 +84,7 @@ class TraceConfigMemoryTestUtil {

"\"%s\""

"],"

"\"memory_dump_config\":{"

+ "\"allowed_dump_modes\":[\"background\"],"

"\"triggers\":["

"{"

"\"mode\":\"background\","