base/trace_event/memory_dump_request_args.h - Issue 2041583003: [tracing] Introduce "allowed_dump_modes" for memory dump config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_request_args.h

Issue 2041583003: [tracing] Introduce "allowed_dump_modes" for memory dump config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@background_config

Patch Set: Fixes and rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/memory_dump_manager.h ('K') | « base/trace_event/memory_dump_manager_unittest.cc ('k') | base/trace_event/trace_config.h » ('j') | content/browser/tracing/background_tracing_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/memory_dump_request_args.h

diff --git a/base/trace_event/memory_dump_request_args.h b/base/trace_event/memory_dump_request_args.h

index 74ec5dc18533c446e6fbd96672b20f0672de63a2..0edac9a59a4b186e88e90cafeaa8471abdf8e64d 100644

--- a/base/trace_event/memory_dump_request_args.h

+++ b/base/trace_event/memory_dump_request_args.h

@@ -28,7 +28,7 @@ enum class MemoryDumpType {

};

// Tells the MemoryDumpProvider(s) how much detailed their dumps should be.

-enum class MemoryDumpLevelOfDetail {

+enum class MemoryDumpLevelOfDetail : uint32_t {

// For background tracing mode. The dump time is quick, and typically just the

// totals are expected. Suballocations need not be specified. Dump name must

// contain only pre-defined strings and string arguments cannot be added.

@@ -44,7 +44,7 @@ enum class MemoryDumpLevelOfDetail {

// Unrestricted amount of entries per dump.

DETAILED,

- // For IPC Macros.

+ FIRST = BACKGROUND,

LAST = DETAILED

};