Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2041553002: Check Android version before calling UsbInterface.getAlternateSetting() (Closed)

Created:
4 years, 6 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
juncai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check Android version before calling UsbInterface.getAlternateSetting() This method (and support for alternate interface settings in general) was only added in API level 21. We must assume that only the default alternate interface will be reported in older API levels. BUG=617032 Committed: https://crrev.com/03b3611b4ad95a5b3f9e21c70f9327ad0a29f10b Cr-Commit-Position: refs/heads/master@{#397849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M device/usb/usb_interface_android.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 6 months ago (2016-06-03 22:32:34 UTC) #2
juncai
LGTM.
4 years, 6 months ago (2016-06-03 23:04:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041553002/1
4 years, 6 months ago (2016-06-03 23:07:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 23:59:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:01:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03b3611b4ad95a5b3f9e21c70f9327ad0a29f10b
Cr-Commit-Position: refs/heads/master@{#397849}

Powered by Google App Engine
This is Rietveld 408576698