Implement cc::Selection<gfx::SelectionBound> StructTraits

Implement cc::Selection<gfx::SelectionBound> StructTraits

BUG=611802
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e9281f3c1dff857b60ddbbd38ac7a045955f5ec4
Cr-Commit-Position: refs/heads/master@{#397892}

[Fady Samuel, 2016-06-03 20:32:04]

Description was changed from

==========
Implement cc::Selection<gfx::SelectionBound> StructTraits

BUG=611802
==========

to

==========
Implement cc::Selection<gfx::SelectionBound> StructTraits

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-06-03 20:32:10]

fsamuel@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-06-03 20:35:40]

lgtm

[Fady Samuel, 2016-06-03 20:50:53]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-03 20:51:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041503002/1

[commit-bot: I haz the power, 2016-06-03 21:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 21:03:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-06-03 21:17:17]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2016-06-03 21:17:18]

Anotine, I'm TBR'ing you as Tom has already reviewed the interesting ipc bits
and I just need a rubberstamp for BUILD bits. Thanks!

[Fady Samuel, 2016-06-03 21:17:42]

Description was changed from

==========
Implement cc::Selection<gfx::SelectionBound> StructTraits

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement cc::Selection<gfx::SelectionBound> StructTraits

BUG=611802
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-06-03 21:17:49]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-03 21:18:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041503002/1

[piman, 2016-06-03 21:28:53]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-06-03 21:29:05]

NAK - why is it in cc?

[Fady Samuel, 2016-06-03 21:32:15]

On 2016/06/03 21:29:05, piman OOO back 2016-6-2 wrote:
> NAK - why is it in cc?

That's where it was before. Does gfx make more sense? I Moved SelectionBound to
gfx:: in a previous CL. I have a TODO to replace LayerSelectionBound with
gfx::SelectionBound. At that point, with everything unified, it makes sense to
just put Selection in gfx. WDYT?

[piman, 2016-06-03 21:32:20]

oh, nvm, that's cc::Selection (I'm not sure why *that* is in cc, but not yours
to fix I guess). LGTM.

[piman, 2016-06-03 21:32:24]

The CQ bit was checked by piman@chromium.org

[piman, 2016-06-03 21:33:05]

On 2016/06/03 21:32:15, Fady Samuel wrote:
> On 2016/06/03 21:29:05, piman OOO back 2016-6-2 wrote:
> > NAK - why is it in cc?
> 
> That's where it was before. Does gfx make more sense? I Moved SelectionBound
to
> gfx:: in a previous CL. I have a TODO to replace LayerSelectionBound with
> gfx::SelectionBound. At that point, with everything unified, it makes sense to
> just put Selection in gfx. WDYT?

Yeah, I think that stuff doesn't belong in cc. I need to take a look at this,
it's very odd.

[commit-bot: I haz the power, 2016-06-03 21:33:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041503002/1

[Fady Samuel, 2016-06-03 21:38:12]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-03 21:38:13]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2041503002/#ps20001
(title: "More android fixing")

[commit-bot: I haz the power, 2016-06-03 21:38:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041503002/20001

[commit-bot: I haz the power, 2016-06-03 21:42:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 21:42:12]

Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Fady Samuel, 2016-06-03 22:09:56]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-03 22:09:57]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2041503002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-06-03 22:10:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041503002/40001

[commit-bot: I haz the power, 2016-06-03 22:30:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 22:30:21]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Fady Samuel, 2016-06-03 22:50:27]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-03 22:50:27]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2041503002/#ps60001
(title: "Remove bad changes")

[commit-bot: I haz the power, 2016-06-03 22:51:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041503002/60001

[commit-bot: I haz the power, 2016-06-03 23:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 23:36:23]

Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Fady Samuel, 2016-06-04 01:12:06]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-04 01:12:06]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2041503002/#ps120001
(title: "Fix deps")

[commit-bot: I haz the power, 2016-06-04 01:12:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041503002/120001

[commit-bot: I haz the power, 2016-06-04 02:26:06]

Description was changed from

==========
Implement cc::Selection<gfx::SelectionBound> StructTraits

BUG=611802
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement cc::Selection<gfx::SelectionBound> StructTraits

BUG=611802
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-04 02:26:08]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-06-04 02:27:23]

Description was changed from

==========
Implement cc::Selection<gfx::SelectionBound> StructTraits

BUG=611802
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement cc::Selection<gfx::SelectionBound> StructTraits

BUG=611802
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e9281f3c1dff857b60ddbbd38ac7a045955f5ec4
Cr-Commit-Position: refs/heads/master@{#397892}
==========

[commit-bot: I haz the power, 2016-06-04 02:27:25]

Patchset 7 (id:??) landed as
https://crrev.com/e9281f3c1dff857b60ddbbd38ac7a045955f5ec4
Cr-Commit-Position: refs/heads/master@{#397892}