Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2041493002: Support tooltips in GuestViews with "--use-cross-process-frames-for-guests" flag. (Closed)

Created:
4 years, 6 months ago by paulmeyer
Modified:
4 years, 6 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support tooltips in GuestViews with "--use-cross-process-frames-for-guests" flag. This was just a matter of plumbing the text to the right place. BUG=609932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/7e1341b3fe622d53dffc76cd993a6c5dde25032e Cr-Commit-Position: refs/heads/master@{#397824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
paulmeyer
4 years, 6 months ago (2016-06-03 19:55:21 UTC) #3
ncarter (slow)
lgtm
4 years, 6 months ago (2016-06-03 20:16:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041493002/1
4 years, 6 months ago (2016-06-03 20:43:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 22:31:19 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 22:34:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e1341b3fe622d53dffc76cd993a6c5dde25032e
Cr-Commit-Position: refs/heads/master@{#397824}

Powered by Google App Engine
This is Rietveld 408576698