[Payments] Partially refactor the PaymentRequestUI

[Payments] Partially refactor the PaymentRequestUI

Recombine the two XML layouts and add logic for adjusting them,
depending on what we're displaying.

BUG=603635
Committed: https://crrev.com/ee366ce9cea1c99f0b2f4a81b097a3cdf7506d79
Cr-Commit-Position: refs/heads/master@{#397893}

[gone, 2016-06-03 19:10:23]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2016-06-03 22:18:35]

https://codereview.chromium.org/2041483002/diff/60001/chrome/android/java/res...
File chrome/android/java/res/layout/payment_request.xml (right):

https://codereview.chromium.org/2041483002/diff/60001/chrome/android/java/res...
chrome/android/java/res/layout/payment_request.xml:26: <FrameLayout
Any thoughts in putting the FrameLayout, ProgressBar, and TextView into separate
a xml file that we'd use <include> here?

We'd have two xml files for request and result, but would require less mucking
around in the code?

https://codereview.chromium.org/2041483002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/2041483002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:231:
mResultView = new PaymentResultView(mContext, title, origin);
I guess in theory we don't need to create this until later, but this allows it
to be final.  Seems ok for now.

https://codereview.chromium.org/2041483002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultView.java
(right):

https://codereview.chromium.org/2041483002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultView.java:23:
public class PaymentResultView {
View in the name really makes me think it should be an Android view of some
sort.  I'm sure the addition of Manager, Handler, Delegate, Builder, Factory,
Provider would really clear it up and make it super obvious :-/

[gone, 2016-06-03 22:26:45]

https://codereview.chromium.org/2041483002/diff/60001/chrome/android/java/res...
File chrome/android/java/res/layout/payment_request.xml (right):

https://codereview.chromium.org/2041483002/diff/60001/chrome/android/java/res...
chrome/android/java/res/layout/payment_request.xml:26: <FrameLayout
On 2016/06/03 22:18:35, Ted C wrote:
> Any thoughts in putting the FrameLayout, ProgressBar, and TextView into
separate
> a xml file that we'd use <include> here?
> 
> We'd have two xml files for request and result, but would require less mucking
> around in the code?

The FrameLayout and TextView aren't exactly the same (e.g. request has a close
button in the FrameLayout but result doesn't).  Don't know what you'd gain since
you'd still be mucking with it.  It'd be slightly better if this was a
RelativeLayout, but then I might still have to muck with margins.

Your call.

[gone, 2016-06-03 22:55:56]

Renamed the "View" and kept the layouts the same, as discussed offline during
our don't-care-off.

[Ted C, 2016-06-03 23:26:51]

lgtm

[gone, 2016-06-03 23:27:18]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-06-03 23:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041483002/80001

[commit-bot: I haz the power, 2016-06-04 00:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-04 00:36:35]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gone, 2016-06-04 01:58:23]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-06-04 01:58:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041483002/80001

[commit-bot: I haz the power, 2016-06-04 02:31:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-04 02:32:54]

Description was changed from

==========
[Payments] Partially refactor the PaymentRequestUI

Recombine the two XML layouts and add logic for adjusting them,
depending on what we're displaying.

BUG=603635
==========

to

==========
[Payments] Partially refactor the PaymentRequestUI

Recombine the two XML layouts and add logic for adjusting them,
depending on what we're displaying.

BUG=603635

Committed: https://crrev.com/ee366ce9cea1c99f0b2f4a81b097a3cdf7506d79
Cr-Commit-Position: refs/heads/master@{#397893}
==========

[commit-bot: I haz the power, 2016-06-04 02:32:55]

Patchset 5 (id:??) landed as
https://crrev.com/ee366ce9cea1c99f0b2f4a81b097a3cdf7506d79
Cr-Commit-Position: refs/heads/master@{#397893}