Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2041423003: Converts ShellObserver from aura::Window to ash::WmWindow (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts ShellObserver from aura::Window to ash::WmWindow BUG=581868 TEST=none R=msw@chromium.org Committed: https://crrev.com/80556bc42607c6bd8d909285173f88bf6103ed4f Cr-Commit-Position: refs/heads/master@{#398406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -66 lines) Patch
M ash/app_list/app_list_presenter_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/aura/wm_root_window_controller_aura.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/aura/wm_root_window_controller_aura.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/high_contrast/high_contrast_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/high_contrast/high_contrast_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ash/shelf/shelf.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/shelf/shelf_window_watcher.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ash/shell.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/shell.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/shell_observer.h View 2 chunks +7 lines, -9 lines 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ash/wm/screen_dimmer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_dimmer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 6 months ago (2016-06-07 21:14:45 UTC) #1
msw
lgtm
4 years, 6 months ago (2016-06-07 22:27:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041423003/1
4 years, 6 months ago (2016-06-07 22:39:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 22:46:26 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 22:49:36 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/80556bc42607c6bd8d909285173f88bf6103ed4f
Cr-Commit-Position: refs/heads/master@{#398406}

Powered by Google App Engine
This is Rietveld 408576698