Moves MruWindowTracker to WmShell

Moves MruWindowTracker to WmShell

We could also go with a ShellCommon and keep WmShell pure virtual, but
as this code is temporary I'm ok with making WmShell not pure virtual.

BUG=617789
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4
Cr-Commit-Position: refs/heads/master@{#398599}

[sky, 2016-06-07 17:37:08]

Description was changed from

==========
Moves ownership of MruWindowTracker to WmShell

We could also go with a ShellCommon and keep WmShell pure virtual, but
as this code is temporary I'm ok with making WmShell not pure virtual.

BUG=617789
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Moves MruWindowTracker to WmShell

We could also go with a ShellCommon and keep WmShell pure virtual, but
as this code is temporary I'm ok with making WmShell not pure virtual.

BUG=617789
TEST=covered by tests
R=jamescook@chromium.org
==========

[James Cook, 2016-06-08 00:45:59]

I'm unclear on the path forward for ash::Shell. Is your thought to migrate code
out of ash::Shell to a common location (here WmShell) until ash::Shell can be
removed?

Keeping WmShell pure virtual appeals to me. For one thing, it would allow it to
be mocked in tests, rather than bringing up all of ash just to access one thing.
However, I agree that introducing WmShellCommon isn't great.

While there's a lot of initialization/shutdown code in ash::Shell, there's not
that much "logic". For things like this sort of controller class, or delegate
objects, we could also add members to WmShellMus to replicate the ones in
ash::Shell, with a long-term plan to end up in a world with WmShell as the
pure-virtual interface to a single WmShell implementation from mus.

OTOH, we might end up in a world where we need shared logic between WmShellAura
and WmShellMus anyway.

WDYT?  Do you think we can avoid a common non-virtual WmShelf class, or do you
think it's inevitable? Try adding stuff to WmShellMus for a little while, or
build the common class now?

[sky, 2016-06-08 15:42:47]

As discussed in person I've updated the patch.

[James Cook, 2016-06-08 15:48:21]

https://codereview.chromium.org/2041423002/diff/120001/ash/common/shell_common.h
File ash/common/shell_common.h (right):

https://codereview.chromium.org/2041423002/diff/120001/ash/common/shell_commo...
ash/common/shell_common.h:18: class ASH_EXPORT ShellCommon {
I would prefer to call this WmShellCommon and the variables wm_shell_common_,
because it's the common piece of the two WmShell* implementations.

I have had significant confusion in the Shelf code due to variable and class
names, and I'm trying to be very explicit about what is Shelf and what is
WmShelf. I think we should do the same with Shell vs. WmShell.

[James Cook, 2016-06-08 15:50:36]

Assuming you're OK with the rename, LGTM

[sky, 2016-06-08 16:04:45]

WmShellCommon, and renamed variables it is.

[sky, 2016-06-08 16:04:49]

The CQ bit was checked by sky@chromium.org

[sky, 2016-06-08 16:04:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2041423002/#ps140001
(title: "wm")

[commit-bot: I haz the power, 2016-06-08 16:05:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041423002/140001

[commit-bot: I haz the power, 2016-06-08 16:48:31]

Description was changed from

==========
Moves MruWindowTracker to WmShell

We could also go with a ShellCommon and keep WmShell pure virtual, but
as this code is temporary I'm ok with making WmShell not pure virtual.

BUG=617789
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Moves MruWindowTracker to WmShell

We could also go with a ShellCommon and keep WmShell pure virtual, but
as this code is temporary I'm ok with making WmShell not pure virtual.

BUG=617789
TEST=covered by tests
R=jamescook@chromium.org
==========

[commit-bot: I haz the power, 2016-06-08 16:48:33]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-08 16:54:45]

Description was changed from

==========
Moves MruWindowTracker to WmShell

We could also go with a ShellCommon and keep WmShell pure virtual, but
as this code is temporary I'm ok with making WmShell not pure virtual.

BUG=617789
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Moves MruWindowTracker to WmShell

We could also go with a ShellCommon and keep WmShell pure virtual, but
as this code is temporary I'm ok with making WmShell not pure virtual.

BUG=617789
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4
Cr-Commit-Position: refs/heads/master@{#398599}
==========

[commit-bot: I haz the power, 2016-06-08 16:54:47]

Patchset 8 (id:??) landed as
https://crrev.com/50a0112bebf53aabec7f274b8932302a6cbc4fe4
Cr-Commit-Position: refs/heads/master@{#398599}