third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp - Issue 2041363002: Move isColorKeyword out of CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

Issue 2041363002: Move isColorKeyword out of CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: V2 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_css_value_keywords.py ('k') | third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

index c12d010ef8d7b38f8076349b77db36ec3e03b423..670e863fe3e65b194adccec89837726b95bf80b5 100644

--- a/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

@@ -82,7 +82,7 @@ PassOwnPtr<InterpolableValue> CSSColorInterpolationType::maybeCreateInterpolable

const CSSPrimitiveValue& primitive = toCSSPrimitiveValue(value);

if (!primitive.isValueID())

return nullptr;

- if (!CSSPropertyParser::isColorKeyword(primitive.getValueID()))

+ if (!isColorKeyword(primitive.getValueID()))

return nullptr;

return createInterpolableColor(primitive.getValueID());

}