Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2041333003: Revert of Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness (Closed)

Created:
4 years, 6 months ago by timvolodine
Modified:
4 years, 6 months ago
Reviewers:
Xi Han, pkotwicz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness (patchset #3 id:60001 of https://codereview.chromium.org/2033953002/ ) Reason for revert: looks like this broke the Android Tests (dbg) bot https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg) also see crbug.com/617935 Original issue's description: > Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness > > There seems to be data cached by the OS which is not deleted by > DexLoader#deleteCachedDexes() which is causing the test to be flaky. > This CL changes DexLoaderTest#testLoadAfterDeleteCachedDexes() to test > DexLoader#deleteCachedDexes() in a scenario which is closer to how the function > is used in production. > > The test used to test that calling DexLoader#deleteCachedDexes() would make > DexLoader#load() load a dex file from scratch. > > The CL changes the test to test that: > - DexLoader#deleteCachedDexes() deletes previously extracted dexes from the local > data directory > - It is possible to use reuse a data directory to load several dexes > > BUG=616923 > > Committed: https://crrev.com/c59b7de12ab8878ddfe4df4fe5cd91b0d526b8c2 > Cr-Commit-Position: refs/heads/master@{#398198} TBR=hanxi@chromium.org,pkotwicz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616923 Committed: https://crrev.com/1514931b7dd9bcb5706e2dfa32e3d4e64f60d887 Cr-Commit-Position: refs/heads/master@{#398281}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
timvolodine
Created Revert of Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness
4 years, 6 months ago (2016-06-07 12:42:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041333003/1
4 years, 6 months ago (2016-06-07 12:42:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 12:43:32 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 12:46:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1514931b7dd9bcb5706e2dfa32e3d4e64f60d887
Cr-Commit-Position: refs/heads/master@{#398281}

Powered by Google App Engine
This is Rietveld 408576698