[SyncFS] Make SyncEngineInitializer run as a background task (3/3)

[SyncFS] Make SyncEngineInitializer run as a background task

BUG=344769
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260250

[tzik, 2014-03-27 08:17:15]

This is SequentialSyncTask to SyncTask conversion for SyncEngineInitializer.
Could you take a look?

[nhiroki, 2014-03-28 03:47:25]

lgtm

https://codereview.chromium.org/204133004/diff/20001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
(right):

https://codereview.chromium.org/204133004/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc:76:
in_memory_env_.get());
nit: Can you make up these inconsistency indents?

[tzik, 2014-03-28 04:55:07]

https://codereview.chromium.org/204133004/diff/20001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
(right):

https://codereview.chromium.org/204133004/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc:76:
in_memory_env_.get());
On 2014/03/28 03:47:26, nhiroki wrote:
> nit: Can you make up these inconsistency indents?

Done.

[tzik, 2014-03-28 12:05:09]

The CQ bit was checked by tzik@chromium.org

[tzik, 2014-03-28 12:05:13]

The CQ bit was unchecked by tzik@chromium.org

[tzik, 2014-03-28 12:06:44]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-03-28 12:12:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/204133004/60001

[commit-bot: I haz the power, 2014-03-28 12:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 12:13:18]

Failed to apply patch for
chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
  Hunk #1 FAILED at 94.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc.rej

Patch:      
chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
Index:
chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
diff --git
a/chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
b/chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
index
3c484d6f9d7b3440b4c6360297085642ca2ad380..8e2b25d83a0f384c97a9944f2d08868764a0304a
100644
---
a/chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
+++
b/chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
@@ -94,16 +94,29 @@ class ConflictResolverTest : public testing::Test {
   }
 
   void InitializeMetadataDatabase() {
-    SyncEngineInitializer initializer(context_.get(),
-                                      base::MessageLoopProxy::current(),
-                                      context_->GetDriveService(),
-                                      database_dir_.path(),
-                                      in_memory_env_.get());
+    SyncEngineInitializer* initializer =
+        new SyncEngineInitializer(context_.get(),
+                                  base::MessageLoopProxy::current(),
+                                  context_->GetDriveService(),
+                                  database_dir_.path(),
+                                  in_memory_env_.get());
     SyncStatusCode status = SYNC_STATUS_UNKNOWN;
-    initializer.RunSequential(CreateResultReceiver(&status));
+    sync_task_manager_->ScheduleSyncTask(
+        FROM_HERE,
+        scoped_ptr<SyncTask>(initializer),
+        SyncTaskManager::PRIORITY_MED,
+        base::Bind(&ConflictResolverTest::DidInitializeMetadataDatabase,
+                   base::Unretained(this), initializer, &status));
+
     base::RunLoop().RunUntilIdle();
     EXPECT_EQ(SYNC_STATUS_OK, status);
-    context_->SetMetadataDatabase(initializer.PassMetadataDatabase());
+  }
+
+  void DidInitializeMetadataDatabase(SyncEngineInitializer* initializer,
+                                     SyncStatusCode* status_out,
+                                     SyncStatusCode status) {
+    context_->SetMetadataDatabase(initializer->PassMetadataDatabase());
+    *status_out = status;
   }
 
   void RegisterApp(const std::string& app_id,

[tzik, 2014-03-28 17:17:36]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-03-28 17:22:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/204133004/60001

[commit-bot: I haz the power, 2014-03-28 20:07:48]

Change committed as 260250