PRESUBMIT.py - Issue 2041313002: infra: check in recipes running on master.chromium.infra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2041313002: infra: check in recipes running on master.chromium.infra (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: presubmit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 0e89fb2e36ae323acdc1960aa2a1dda8ded2ac0c..cbf19b635e97d866c809229915b8266cca696e76 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -267,6 +267,7 @@ def PylintChecks(input_api, output_api): # pragma: no cover

black_list = list(input_api.DEFAULT_BLACK_LIST)

black_list += DISABLED_PROJECTS

black_list += ['.*\.pyc$', '.*_pb2\.py']

+ black_list += [r'^recipes/recipes\.py$']

Sergiy Byelozyorov 2016/06/07 12:00:00 Why is this needed? Can we fix recipes.py instead?

Paweł Hajdan Jr. 2016/06/07 12:07:18 Other repos also have it. It generates pylint warn

Sergiy Byelozyorov 2016/06/07 13:19:46 We've discussed it offline and Pawel added comment

black_list += IgnoredPaths(input_api)

extra_syspaths = [venv_path]

« no previous file with comments | « no previous file | infra/config/recipes.cfg » ('j') | no next file with comments »