Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2320)

Unified Diff: chrome/browser/ui/browser_view_prefs.cc

Issue 2041293002: Add heuristics to limit showing of new backspace UI bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac compile Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_view_prefs.cc
diff --git a/chrome/browser/ui/browser_view_prefs.cc b/chrome/browser/ui/browser_view_prefs.cc
index 3232859dfc2110e43a4e9da7c8916756ce13bd3b..c38a79ffe15966efe3ddc7dd24d49c75168cc2cc 100644
--- a/chrome/browser/ui/browser_view_prefs.cc
+++ b/chrome/browser/ui/browser_view_prefs.cc
@@ -36,9 +36,10 @@ void RegisterBrowserViewProfilePrefs(
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
custom_frame_default = ui::GetCustomFramePrefDefault();
#endif
-
registry->RegisterBooleanPref(prefs::kUseCustomChromeFrame,
Matt Giuca 2016/06/08 01:29:03 nit: Any reason to delete the above line? If anyth
Peter Kasting 2016/06/09 19:49:31 The code above is closely tied to this line: it's
Matt Giuca 2016/06/10 01:07:05 Acknowledged.
custom_frame_default);
+
+ registry->RegisterIntegerPref(prefs::kBackShortcutBubbleShownCount, 0);
Matt Giuca 2016/06/08 01:29:03 I think we should have separate counters for the B
Peter Kasting 2016/06/09 19:49:31 My instinct is that one counter for both is the wa
Matt Giuca 2016/06/10 01:07:05 Not particularly :)
}
void MigrateBrowserTabStripPrefs(PrefService* prefs) {

Powered by Google App Engine
This is Rietveld 408576698