Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 2041293002: Add heuristics to limit showing of new backspace UI bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/compiler_specific.h" 13 #include "base/compiler_specific.h"
14 #include "base/gtest_prod_util.h" 14 #include "base/gtest_prod_util.h"
15 #include "base/macros.h" 15 #include "base/macros.h"
16 #include "base/time/time.h"
16 #include "base/timer/timer.h" 17 #include "base/timer/timer.h"
17 #include "build/build_config.h" 18 #include "build/build_config.h"
18 #include "chrome/browser/devtools/devtools_window.h" 19 #include "chrome/browser/devtools/devtools_window.h"
19 #include "chrome/browser/extensions/extension_commands_global_registry.h" 20 #include "chrome/browser/extensions/extension_commands_global_registry.h"
20 #include "chrome/browser/extensions/extension_keybinding_registry.h" 21 #include "chrome/browser/extensions/extension_keybinding_registry.h"
21 #include "chrome/browser/ui/browser.h" 22 #include "chrome/browser/ui/browser.h"
22 #include "chrome/browser/ui/browser_window.h" 23 #include "chrome/browser/ui/browser_window.h"
23 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h" 24 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
24 #include "chrome/browser/ui/infobar_container_delegate.h" 25 #include "chrome/browser/ui/infobar_container_delegate.h"
25 #include "chrome/browser/ui/signin_view_controller.h" 26 #include "chrome/browser/ui/signin_view_controller.h"
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 ExclusiveAccessBubbleType bubble_type, 281 ExclusiveAccessBubbleType bubble_type,
281 bool with_toolbar) override; 282 bool with_toolbar) override;
282 void ExitFullscreen() override; 283 void ExitFullscreen() override;
283 void UpdateExclusiveAccessExitBubbleContent( 284 void UpdateExclusiveAccessExitBubbleContent(
284 const GURL& url, 285 const GURL& url,
285 ExclusiveAccessBubbleType bubble_type) override; 286 ExclusiveAccessBubbleType bubble_type) override;
286 void OnExclusiveAccessUserInput() override; 287 void OnExclusiveAccessUserInput() override;
287 bool ShouldHideUIForFullscreen() const override; 288 bool ShouldHideUIForFullscreen() const override;
288 bool IsFullscreen() const override; 289 bool IsFullscreen() const override;
289 bool IsFullscreenBubbleVisible() const override; 290 bool IsFullscreenBubbleVisible() const override;
290 void ShowNewBackShortcutBubble(bool forward) override; 291 void MaybeShowNewBackShortcutBubble(bool forward) override;
292 void HideNewBackShortcutBubble() override;
291 LocationBar* GetLocationBar() const override; 293 LocationBar* GetLocationBar() const override;
292 void SetFocusToLocationBar(bool select_all) override; 294 void SetFocusToLocationBar(bool select_all) override;
293 void UpdateReloadStopState(bool is_loading, bool force) override; 295 void UpdateReloadStopState(bool is_loading, bool force) override;
294 void UpdateToolbar(content::WebContents* contents) override; 296 void UpdateToolbar(content::WebContents* contents) override;
295 void ResetToolbarTabState(content::WebContents* contents) override; 297 void ResetToolbarTabState(content::WebContents* contents) override;
296 void FocusToolbar() override; 298 void FocusToolbar() override;
297 ToolbarActionsBar* GetToolbarActionsBar() override; 299 ToolbarActionsBar* GetToolbarActionsBar() override;
298 void ToolbarSizeChanged(bool is_animating) override; 300 void ToolbarSizeChanged(bool is_animating) override;
299 void FocusAppMenu() override; 301 void FocusAppMenu() override;
300 void FocusBookmarksToolbar() override; 302 void FocusBookmarksToolbar() override;
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
662 bool handling_theme_changed_; 664 bool handling_theme_changed_;
663 665
664 // True when in ProcessFullscreen(). The flag is used to avoid reentrance and 666 // True when in ProcessFullscreen(). The flag is used to avoid reentrance and
665 // to ignore requests to layout while in ProcessFullscreen() to reduce 667 // to ignore requests to layout while in ProcessFullscreen() to reduce
666 // jankiness. 668 // jankiness.
667 bool in_process_fullscreen_; 669 bool in_process_fullscreen_;
668 670
669 std::unique_ptr<ExclusiveAccessBubbleViews> exclusive_access_bubble_; 671 std::unique_ptr<ExclusiveAccessBubbleViews> exclusive_access_bubble_;
670 672
671 std::unique_ptr<NewBackShortcutBubble> new_back_shortcut_bubble_; 673 std::unique_ptr<NewBackShortcutBubble> new_back_shortcut_bubble_;
674 base::TimeTicks last_back_shortcut_press_time_;
672 675
673 #if defined(OS_WIN) 676 #if defined(OS_WIN)
674 // Helper class to listen for completion of first page load. 677 // Helper class to listen for completion of first page load.
675 std::unique_ptr<LoadCompleteListener> load_complete_listener_; 678 std::unique_ptr<LoadCompleteListener> load_complete_listener_;
676 679
677 // The custom JumpList for Windows 7. 680 // The custom JumpList for Windows 7.
678 scoped_refptr<JumpList> jumplist_; 681 scoped_refptr<JumpList> jumplist_;
679 #endif 682 #endif
680 683
681 // The timer used to update frames for the Loading Animation. 684 // The timer used to update frames for the Loading Animation.
(...skipping 14 matching lines...) Expand all
696 // The class that registers for keyboard shortcuts for extension commands. 699 // The class that registers for keyboard shortcuts for extension commands.
697 std::unique_ptr<ExtensionKeybindingRegistryViews> 700 std::unique_ptr<ExtensionKeybindingRegistryViews>
698 extension_keybinding_registry_; 701 extension_keybinding_registry_;
699 702
700 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_; 703 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
701 704
702 DISALLOW_COPY_AND_ASSIGN(BrowserView); 705 DISALLOW_COPY_AND_ASSIGN(BrowserView);
703 }; 706 };
704 707
705 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 708 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698