Add heuristics to limit showing of new backspace UI bubble.

chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h"
 
 #include "chrome/browser/download/download_shelf.h"
 #include "chrome/browser/fullscreen.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/cocoa/accelerators_cocoa.h"
@@ skipping 22 matching lines @@
 
 ExclusiveAccessController::~ExclusiveAccessController() {}
 
 void ExclusiveAccessController::Show() {
   // Hide the backspace shortcut bubble, to avoid overlapping.
   new_back_shortcut_bubble_.reset();
 
   views_bubble_.reset(new ExclusiveAccessBubbleViews(this, url_, bubble_type_));
 }
 
-void ExclusiveAccessController::ShowNewBackShortcutBubble(bool forward) {
-  // Hide the exclusive access bubble, to avoid overlapping.
-  views_bubble_.reset();
+void ExclusiveAccessController::MaybeShowNewBackShortcutBubble(bool forward) {
+  if (!new_back_shortcut_bubble_ || !new_back_shortcut_bubble_->IsVisible()) {

[Peter Kasting, 2016/06/07 08:04:23]

I don't love the fact that this almost exactly duplicates the code in
browser_view.cc.

I thought about placing this logic inside NewBackShortcutBubble itself, but that
seemed somehow wrong -- having callers create it and tell it to show, but it
actually deciding to keep itself hidden until later.

I wasn't sure if there was another good spot to put this code that would be
shared across platforms.  I suppose I could just say "it'll only be in for a few
milestones, who cares".

Your feedback welcome.

[Matt Giuca, 2016/06/08 01:29:03]

Yeah I went through a similar thought process before I found this comment.
Unfortunate but I think you're right; there isn't a "better" place to put this
logic.

Please be sure to keep this version in sync if you make my suggested changes to
the other copy of this code.

+      PrefService* prefs = GetProfile()->GetPrefs();
+      int shown_count = prefs->GetInteger(prefs::kBackShortcutBubbleShownCount);
+      constexpr int kMaxShownCount = 5;
+      if (shown_count >= kMaxShownCount)
+        return;
 
+      const base::TimeTicks now = base::TimeTicks::Now();
+      constexpr base::TimeDelta kRepeatWindow = base::TimeDelta::FromSeconds(3);
+      if (last_back_shortcut_press_time_.is_null() ||
+          ((now - last_back_shortcut_press_time_) > kRepeatWindow)) {
+        last_back_shortcut_press_time_ = now;
+        return;
+      }
+
+      // Hide the exclusive access bubble, to avoid overlapping.
+      views_bubble_.reset();
+
+      new_back_shortcut_bubble_.reset(new NewBackShortcutBubble(this, forward));
+      prefs->SetInteger(prefs::kBackShortcutBubbleShownCount, shown_count + 1);
+      last_back_shortcut_press_time_ = base::TimeTicks();
+  }
+
+  new_back_shortcut_bubble_->UpdateContent(forward);
+}
+
+void ExclusiveAccessController::HideNewBackShortcutBubble() {
   if (new_back_shortcut_bubble_)
-    new_back_shortcut_bubble_->UpdateContent(forward);
-  else
-    new_back_shortcut_bubble_.reset(new NewBackShortcutBubble(this, forward));
+    new_back_shortcut_bubble_->Hide();
 }
 
 void ExclusiveAccessController::Destroy() {
   views_bubble_.reset();
   url_ = GURL();
   bubble_type_ = EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE;
 }
 
 void ExclusiveAccessController::Layout(CGFloat max_y) {
   if (views_bubble_)
@@ skipping 119 matching lines @@
 }
 
 gfx::Rect ExclusiveAccessController::GetTopContainerBoundsInScreen() {
   NOTREACHED();  // Only used for ImmersiveMode.
   return gfx::Rect();
 }
 
 BrowserWindow* ExclusiveAccessController::GetBrowserWindow() const {
   return [controller_ browserWindow];
 }