Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2041273002: Remove obsolete friend declarations for MSVC. (Closed)

Created:
4 years, 6 months ago by Yuta Kitamura
Modified:
4 years, 6 months ago
Reviewers:
haraken, *tzik
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete friend declarations for MSVC. These friend declarations were added because MSVC had a bug around the visibility of nested classes. They are no longer necessary. BUG=617504 Committed: https://crrev.com/3d588ed27838ec6df972ccdf662ab0ed39ec9514 Cr-Commit-Position: refs/heads/master@{#398255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M third_party/WebKit/Source/platform/PODArena.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestPaintArtifact.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041273002/1
4 years, 6 months ago (2016-06-07 06:26:16 UTC) #2
Yuta Kitamura
tzik & haraken: PTAL? +haraken for platform/ approval.
4 years, 6 months ago (2016-06-07 06:26:55 UTC) #5
haraken
LGTM
4 years, 6 months ago (2016-06-07 06:27:57 UTC) #6
tzik
lgtm
4 years, 6 months ago (2016-06-07 06:29:03 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/159322)
4 years, 6 months ago (2016-06-07 06:48:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041273002/1
4 years, 6 months ago (2016-06-07 07:38:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 08:24:34 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 08:26:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d588ed27838ec6df972ccdf662ab0ed39ec9514
Cr-Commit-Position: refs/heads/master@{#398255}

Powered by Google App Engine
This is Rietveld 408576698