Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp

Issue 2041263002: Remove the use of OwnedPtrDeleter in WebHelperPlugin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to PS1. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp b/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp
index a479ed64aefdedd1493470c8474ff1531e05cfbf..9a02277127de4e194010247a14be4942684c54cf 100644
--- a/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp
@@ -59,12 +59,12 @@ protected:
FrameTestHelpers::WebViewHelper m_helper;
WebHelperPluginFrameClient m_frameClient;
- OwnPtr<WebHelperPlugin> m_plugin;
+ WebHelperPluginUniquePtr m_plugin;
};
TEST_F(WebHelperPluginTest, CreateAndDestroyAfterWebViewDestruction)
{
- m_plugin = adoptPtr(WebHelperPlugin::create("hello", m_helper.webView()->mainFrame()->toWebLocalFrame()));
+ m_plugin.reset(WebHelperPlugin::create("hello", m_helper.webView()->mainFrame()->toWebLocalFrame()));
EXPECT_TRUE(m_plugin);
EXPECT_TRUE(m_plugin->getPlugin());
@@ -74,7 +74,7 @@ TEST_F(WebHelperPluginTest, CreateAndDestroyAfterWebViewDestruction)
TEST_F(WebHelperPluginTest, CreateAndDestroyBeforeWebViewDestruction)
{
- m_plugin = adoptPtr(WebHelperPlugin::create("hello", m_helper.webView()->mainFrame()->toWebLocalFrame()));
+ m_plugin.reset(WebHelperPlugin::create("hello", m_helper.webView()->mainFrame()->toWebLocalFrame()));
EXPECT_TRUE(m_plugin);
EXPECT_TRUE(m_plugin->getPlugin());
@@ -86,7 +86,7 @@ TEST_F(WebHelperPluginTest, CreateFailsWithPlaceholder)
{
m_frameClient.setCreatePlaceholder(true);
- m_plugin = adoptPtr(WebHelperPlugin::create("hello", m_helper.webView()->mainFrame()->toWebLocalFrame()));
+ m_plugin.reset(WebHelperPlugin::create("hello", m_helper.webView()->mainFrame()->toWebLocalFrame()));
EXPECT_EQ(0, m_plugin.get());
}
« no previous file with comments | « third_party/WebKit/Source/web/WebHelperPluginImpl.cpp ('k') | third_party/WebKit/public/web/WebHelperPlugin.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698