Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2041253002: [PCv2] Reduce page_set repeat 3->2 (Closed)

Created:
4 years, 6 months ago by kouhei (in TOK)
Modified:
4 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PCv2] Reduce page_set repeat 3->2 This CL reduces number of page_set iterations in PCv2, to make the test run fit <60min in slow bots such as "Nexus 5 Perf". Before this CL, PCv2 ran a URL 6 times, where as PCv1 ran a URL 3 times. Which made a single page_cycler_v2.typical25 run take >60min, which caused timeout on the perf bots. BUG=617004 TBR=nednguyen@google.com Committed: https://crrev.com/d18e493aeedfcfaebfbf044e3725a5c3aaf3589d Cr-Commit-Position: refs/heads/master@{#398233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/benchmarks/page_cycler_v2.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041253002/1
4 years, 6 months ago (2016-06-07 04:15:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 05:27:43 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 05:29:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d18e493aeedfcfaebfbf044e3725a5c3aaf3589d
Cr-Commit-Position: refs/heads/master@{#398233}

Powered by Google App Engine
This is Rietveld 408576698