Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2041243002: switch perf and ll_prof loggers to line buffering (Closed)

Created:
4 years, 6 months ago by ofrobots
Modified:
4 years, 6 months ago
Reviewers:
Jarin, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

switch perf and ll_prof loggers to line buffering BUG=v8:5015 R=jarin@chromium.org,yangguo@chromium.org Committed: https://crrev.com/2bcbe2fe2d2d518df357c6aa89f328ae7226b276 Cr-Commit-Position: refs/heads/master@{#36788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M src/log.cc View 4 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041243002/1
4 years, 6 months ago (2016-06-07 02:11:30 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 02:37:06 UTC) #5
ofrobots
Yang, Jaroslav: PTAL.
4 years, 6 months ago (2016-06-07 05:39:30 UTC) #6
Jarin
lgtm. Thanks!
4 years, 6 months ago (2016-06-07 09:29:26 UTC) #7
Yang
On 2016/06/07 09:29:26, Jarin wrote: > lgtm. Thanks! lgtm.
4 years, 6 months ago (2016-06-07 10:40:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041243002/1
4 years, 6 months ago (2016-06-07 13:26:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 13:28:27 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 13:31:03 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bcbe2fe2d2d518df357c6aa89f328ae7226b276
Cr-Commit-Position: refs/heads/master@{#36788}

Powered by Google App Engine
This is Rietveld 408576698