Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2041233007: Fix typos on offline pages (Closed)

Created:
4 years, 6 months ago by Vivian
Modified:
4 years, 6 months ago
Reviewers:
Nico, fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typos on offline pages Fix "kOfflinePageArchviesDirname" to "kOfflineArchivesDirname" at line 58 in chrome_constants.h Fix "OfflienPageArchiver" to "OfflinePageArchiver" at line 46 in recent_tab_helper.h BUG=618428 Committed: https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4 Cr-Commit-Position: refs/heads/master@{#398940}

Patch Set 1 : Fix initial typos #

Patch Set 2 : Fix related issues #

Patch Set 3 : Fix typo in test files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/android/offline_pages/offline_page_model_factory.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/recent_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/test_offline_page_model_builder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (14 generated)
Vivian
4 years, 6 months ago (2016-06-08 22:12:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041233007/20001
4 years, 6 months ago (2016-06-08 22:18:38 UTC) #5
fgorski
lgtm Adding Nico for stamping the files outside of offline_pages
4 years, 6 months ago (2016-06-08 22:22:35 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/84517)
4 years, 6 months ago (2016-06-08 22:38:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041233007/40001
4 years, 6 months ago (2016-06-08 23:03:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/197556)
4 years, 6 months ago (2016-06-08 23:11:58 UTC) #14
chili
Drive-by comment - I'm amused that there's a typo in the description to fix typos ...
4 years, 6 months ago (2016-06-09 07:57:19 UTC) #15
fgorski
On 2016/06/09 07:57:19, chili wrote: > Drive-by comment - > > I'm amused that there's ...
4 years, 6 months ago (2016-06-09 16:05:43 UTC) #16
Nico
lgtm
4 years, 6 months ago (2016-06-09 16:41:29 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041233007/40001
4 years, 6 months ago (2016-06-09 16:56:10 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 17:00:58 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041233007/40001
4 years, 6 months ago (2016-06-09 17:46:15 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 17:52:00 UTC) #26
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 17:56:25 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4
Cr-Commit-Position: refs/heads/master@{#398940}

Powered by Google App Engine
This is Rietveld 408576698